netdev - Re: [PATCH v2] usbnet: fix oops in usbnet_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111107.132655.1787743558315240070.davem@davemloft.net>
Date:	Mon, 07 Nov 2011 13:26:55 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	richardcochran@...il.com
Cc:	khlebnikov@...nvz.org, oneukum@...e.de, michael@...sch.at,
	alexey.orishko@...il.com, netdev@...r.kernel.org, devel@...nvz.org
Subject: Re: [PATCH v2] usbnet: fix oops in usbnet_start_xmit

From: Richard Cochran <richardcochran@...il.com>
Date: Mon, 7 Nov 2011 18:39:19 +0100

> On Mon, Nov 07, 2011 at 06:54:58PM +0300, Konstantin Khlebnikov wrote:
>> This patch fixes the bug added in commit v3.1-rc7-1055-gf9b491e
>> SKB can be NULL at this point, at least for cdc-ncm.
>> 
>> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...nvz.org>
> 
> Acked-by: Richard Cochran <richardcochran@...il.com>

Applied, but the overall logic in the usbnet transmit path definitely
could use a good reconsideration and cleanup.

I'm even open to having generic support at the generic net device TX
level to fixup the segmentation layout of the SKB so that it meets
the device's requirements.  We can do it more efficiently there too.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html