netdev - Re: [PATCH] ipv4: fix a bug in strict route gateway comparation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111108.120710.136890691041522812.davem@davemloft.net>
Date:	Tue, 08 Nov 2011 12:07:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	lw@...fujitsu.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv4: fix a bug in strict route gateway comparation.

From: Li Wei <lw@...fujitsu.com>
Date: Tue, 08 Nov 2011 16:44:40 +0800

> Since commit def57687 (ipv4: Elide use of rt->rt_dst in ip_forward())
> we use iph->daddr for strict route gateway comparation, Unfortunately
> skb_rtable(skb) has been updated in ip_options_rcv_srr() for the
> nexthop in SRR option but iph->daddr *not* updated, So rt->rt_dst is
> not equals to iph->daddr, We should use the updated rt->rt_dst instead.
> 
> Signed-off-by: Li Wei <lw@...fujitsu.com>

Same comments as the other patch, add whatever logic is necessary to
compute the destination address such that we don't need to add back
an rt->rt_dst reference here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html