netdev - Re: dst->obsolete has become pointless

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111108.122020.1080743546477280623.davem@davemloft.net>
Date:	Tue, 08 Nov 2011 12:20:20 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	steffen.klassert@...unet.com
Cc:	netdev@...r.kernel.org, timo.teras@....fi
Subject: Re: dst->obsolete has become pointless

From: Steffen Klassert <steffen.klassert@...unet.com>
Date: Tue, 8 Nov 2011 10:34:24 +0100

> I don't know what to do with DecNET, but we probaply need to decide
> about the future of dst->obsolete before we can fix the ipv4 PMTU
> problems. Possible fixes might depend on whether ->dst_check() is
> always invoked or not.

Simplest thing to do is to move dst->obsolete check into DecNET's
->dst_check() handler, then call ->dst_check() unconditionally.

Then we can just set dst->obsolete to zero for all route types,
and kill the "initial_obsolete" argument to dst_alloc() and
associated logic.

As things are currently implemented, because of how we elide the full
table scan and flush, ipv4 and ipv6 really need to do the serial
number check every time so we have to keep things as they are.

Things get more interesting with the routing cache removed, of course,
but that is still a long ways off. :-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html