netdev - Re: [PATCH 1/1] [SMSC75xx] Fix incorrect usage of NET_IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 08 Nov 2011 12:37:42 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ne@...urth.eu
Cc:	netdev@...r.kernel.org, phil@....cc, stable@...r.kernel.org,
	steve.glendinning@...c.com
Subject: Re: [PATCH 1/1] [SMSC75xx] Fix incorrect usage of NET_IP_ALIGN

From: Nico Erfurth <ne@...urth.eu>
Date: Tue,  8 Nov 2011 18:30:40 +0100

> The driver used NET_IP_ALIGN to remove some additional padding inside of
> the rx_fixup function. On many architectures NET_IP_ALIGN defaults to 2
> which removed the correct amount of bytes.
> 
> On MCORE2-machines commit ea812ca1b06113597adcd8e70c0f84a413d97544
> introduces a change which sets NET_IP_ALIGN to 0 by default. Which
> triggered the bug on these machines.
> 
> This fix introduces a new RXW_PADDING define and uses this instead of
> NET_IP_ALIGN. The name was taken from the original SMSC7500 driver which
> is provided by SMSC.
> 
> Signed-off-by: Nico Erfurth <ne@...urth.eu>
> Tested-by: Phil Sutter <phil@....cc>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html