netdev - Re: PROBLEM: pppol2tp over pppoe NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111108.140000.543570939575214751.davem@davemloft.net>
Date:	Tue, 08 Nov 2011 14:00:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	spiked.yar@...il.com, netdev@...r.kernel.org
Subject: Re: PROBLEM: pppol2tp over pppoe NULL pointer dereference

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 05 Nov 2011 08:40:29 +0100

> Le vendredi 04 novembre 2011 à 22:28 -0400, David Miller a écrit :
>> From: Eric Dumazet <eric.dumazet@...il.com>
>> Date: Wed, 02 Nov 2011 00:58:13 +0100
>> 
>> > Please try following patch, thanks !
>> > 
>> > [PATCH] l2tp: handle fragmented skbs in receive path
>> > 
>> > Modern drivers provide skb with fragments, and L2TP doesnt properly
>> > handles them.
>> > 
>> > Some bad frames can also trigger panics because of insufficent checks.
>> > 
>> > Reported-by: Misha Labjuk <spiked.yar@...il.com>
>> > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
>> 
>> I'm still waiting for testing results of this patch.
> 
> Of course.
> 
> If you prefer, I can submit a smaller patch for the obvious bug first,
> and I can respin the thing when net-next reopens.
> 
> [PATCH] l2tp: fix l2tp_udp_recv_core()
> 
> pskb_may_pull() can change skb->data, so we have to load ptr/optr at the
> right place.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Yes, this is easier to digest right now.

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html