netdev - Re: [PATCH] libteam: fix function names to include 'bond'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111109212308.4f89739e@asterix.rh>
Date:	Wed, 9 Nov 2011 21:23:08 -0200
From:	Flavio Leitner <fbl@...hat.com>
To:	Jiri Pirko <jpirko@...hat.com>
Cc:	netdev <netdev@...r.kernel.org>, davem@...emloft.net,
	eric.dumazet@...il.com, bhutchings@...arflare.com,
	shemminger@...tta.com, fubar@...ibm.com, andy@...yhouse.net,
	tgraf@...radead.org, ebiederm@...ssion.com, mirqus@...il.com,
	kaber@...sh.net, greearb@...delatech.com, jesse@...ira.com,
	benjamin.poirier@...il.com, jzupka@...hat.com
Subject: Re: [PATCH] libteam: fix function names to include 'bond'

On Wed, 9 Nov 2011 23:04:25 +0100
Jiri Pirko <jpirko@...hat.com> wrote:

> 
> Hi Flavio.
> 
> Thomas included these 2 functions in latest libnl upstream. Bond
> versions wouldn't work because of "bond" type check.
> 

Yeah, my first option would be using git repo, but the one
mentioned in the page seems to be off and I am not finding
another one.  Do you have the repo url handy?

Anyway, I've tried here with my patch applied and it didn't work.
Every packet transmitted increased TX dropped in ifconfig team0
output. The tcpdump attached to the slave doesn't show anything,
the packets appear only when attached to team0.

When I ping the team0 host from another host, both slave and
team0 RX dropped increases at the same rate. tcpdump attached
to the slave shows the packet coming.

Well, maybe this is an effect of having used the wrong libnl
version, though the team_monitor seems to be working just fine.
(patch applied on top of net-next of today, commit e56c57d,
 followed the exact same steps as in HOWTO.BASICS)

I am planning to upgrade the system to the new fedora and
try again after that.  If I have time, I will follow up with
fresh results.

thanks,
fbl

> Jirka
> 
> Wed, Nov 09, 2011 at 07:20:46PM CET, fbl@...hat.com wrote:
> >Signed-off-by: Flavio Leitner <fbl@...hat.com>
> >---
> >
> > I found those while trying to test V6 patch using latest
> > libteam (commit 5e9790816606a6dd4e7f6f32c0bb0c45e5d13b31)
> > and libnl-3.2.2 (last stable).
> > thanks,
> > fbl
> >
> > lib/libteam.c |    4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/lib/libteam.c b/lib/libteam.c
> >index feb13b6..e7ae6b0 100644
> >--- a/lib/libteam.c
> >+++ b/lib/libteam.c
> >@@ -1331,7 +1331,7 @@ int team_port_add(struct team_handle *th,
> >uint32_t port_ifindex)
> > {
> > 	int err;
> > 
> >-	err = rtnl_link_enslave_ifindex(th->nl_cli.sock,
> >th->ifindex,
> >+	err = rtnl_link_bond_enslave_ifindex(th->nl_cli.sock,
> >th->ifindex,
> > 					port_ifindex);
> > 	return -nl2syserr(err);
> > }
> >@@ -1350,6 +1350,6 @@ int team_port_remove(struct team_handle *th,
> >uint32_t port_ifindex)
> > {
> > 	int err;
> > 
> >-	err = rtnl_link_release_ifindex(th->nl_cli.sock,
> >port_ifindex);
> >+	err = rtnl_link_bond_release_ifindex(th->nl_cli.sock,
> >port_ifindex);
> > 	return -nl2syserr(err);
> > }
> >-- 
> >1.7.6
> >

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html