netdev - Re: [PATCH] drivers/net/usb/asix: resync from vendor's copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Nov 2011 16:34:04 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Mark Lord <kernel@...savvy.com>
CC:	David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/net/usb/asix:  resync from vendor's copy

On Wed, 2011-11-09 at 11:25 -0500, Mark Lord wrote:
> On 11-11-02 04:42 PM, Ben Hutchings wrote:
> > On Wed, 2011-11-02 at 15:36 -0400, Mark Lord wrote:
> > [...]
> >> First cut (for review) at updating the in-kernel asix usb/network driver
> >> from the latest vendor GPL version of the driver, obtained from here:
> >>
> >>   http://www.asix.com.tw/download.php?sub=searchresult&PItemID=84&download=driver
> ..
> >> --- linux-3.0/drivers/net/usb/asix.c	2011-10-12 17:59:03.000000000 -0400
> >> +++ linux/drivers/net/usb/asix.c	2011-11-01 19:00:50.051289683 -0400
> > [...]
> ...
> >> +	.set_tx_csum		= ax88772b_set_tx_csum,
> >> +	.get_tx_csum		= ax88772b_get_tx_csum,
> >> +	.get_rx_csum		= ax88772b_get_rx_csum,
> >> +	.set_rx_csum		= ax88772b_set_rx_csum,
> >> +};
> > 
> > The various ethtool operations for offload flags are being (or have
> > been) removed.  The driver must set net_device::hw_features and
> > implement net_device_ops::ndo_set_features instead.
> 
> Okay, I see what to do for the rx_csum stuff, based on other drivers.
> 
> But is there anything to replace the tx_csum stuff,
> or should I just remove it entirely without a substitute?

If TX checksum offload only needs to be requested in TX descriptors and
not in a configuration register, then you don't need to do anything when
it's enabled or disabled.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html