netdev - Re: [patch net-next V7] net: introduce ethernet teaming device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111110165944.GA2078@minipsycho>
Date:	Thu, 10 Nov 2011 17:59:45 +0100
From:	Jiri Pirko <jpirko@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	bhutchings@...arflare.com, shemminger@...tta.com, fubar@...ibm.com,
	andy@...yhouse.net, tgraf@...radead.org, ebiederm@...ssion.com,
	mirqus@...il.com, kaber@...sh.net, greearb@...delatech.com,
	jesse@...ira.com, fbl@...hat.com, benjamin.poirier@...il.com,
	jzupka@...hat.com, ivecera@...hat.com
Subject: Re: [patch net-next V7] net: introduce ethernet teaming device

Thu, Nov 10, 2011 at 05:02:10PM CET, eric.dumazet@...il.com wrote:
>Le jeudi 10 novembre 2011 à 16:41 +0100, Jiri Pirko a écrit :
>> This patch introduces new network device called team. It supposes to be
>> very fast, simple, userspace-driven alternative to existing bonding
>> driver.
>> 
>
>> +static bool team_dummy_transmit(struct team *team, struct sk_buff *skb)
>> +{
>> +	dev_kfree_skb(skb);
>> +	return false;
>> +}
>> +
>
>ndo_start_xmit() method can be called with IRQ disabled (netpoll ?), so
>dev_kfree_skb_any() is better ?
>

For example bonding is using dev_kfree_skb in xmit as well.
I propose this to be eventually addressed in follow-up patch.


>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html