netdev - Re: [PATCH net-next 09/13] bnx2x: add pri

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM8tLiN=E2=a0TEYgw6mc70-vJU0dHjP4F4PpKUk8+3zvQPnAg@mail.gmail.com>
Date:	Thu, 10 Nov 2011 22:21:45 +0200
From:	Dmitry Kravkov <dkravkov@...il.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Dmitry Kravkov <dmitry@...adcom.com>, davem@...emloft.net,
	netdev@...r.kernel.org, Ariel Elior <ariele@...adcom.com>,
	Eilon Greenstein <eilong@...adcom.com>
Subject: Re: [PATCH net-next 09/13] bnx2x: add pri_map module parameter

Resending for netdev
On Thu, Nov 10, 2011 at 10:18 PM, Dmitry Kravkov <dkravkov@...il.com> wrote:
>
> On Thu, Nov 10, 2011 at 7:39 PM, Ben Hutchings <bhutchings@...arflare.com> wrote:
>>
>> On Thu, 2011-11-10 at 17:14 +0200, Dmitry Kravkov wrote:
>> > From: Ariel Elior <ariele@...adcom.com>
>> >
>> > The optional parameter pri_map is used to map the
>> > skb->priority to a Class Of Service (CoS) in the HW.
>> > This 32 bit parameter is evaluated by the  driver as 8
>> > values of 4 bits each. Each nibble sets the desired
>> > HW queue number for that priority.
>> [...]
>>
>> You should implement ndo_tc_setup instead of adding a driver-specific
>> parameter (that should be per-device anyway).
>
> bnx2x has ndo_setup_tc, but the callback configures device for number of traffic
> only, when actual mapping of priority to cos is done according to DCB negotiation.
> The parameter allow user to force mapping if the link partner is not DCB capable.
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html