[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 11 Nov 2011 09:28:17 +0200
From: Baruch Siach <baruch@...s.co.il>
To: Richard Zhao <richard.zhao@...aro.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
linux-mmc@...r.kernel.org, netdev@...r.kernel.org,
linux-serial@...r.kernel.org, amit.kucheria@...onical.com,
linux@....linux.org.uk, kernel@...gutronix.de,
eric.miao@...aro.org, ben-linux@...ff.org, cjb@...top.org,
alan@...ux.intel.com
Subject: Re: [PATCH V2 01/14] clk: add helper functions clk_prepare_enable
and clk_disable_unprepare
Hi Richard,
On Fri, Nov 11, 2011 at 09:10:16AM +0800, Richard Zhao wrote:
> Signed-off-by: Richard Zhao <richard.zhao@...aro.org>
> ---
> include/linux/clk.h | 19 +++++++++++++++++++
> 1 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/clk.h b/include/linux/clk.h
> index 7213b52..63985f7 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> @@ -107,6 +107,25 @@ static inline void clk_unprepare(struct clk *clk)
> }
> #endif
>
> +static inline int clk_prepare_enable(struct clk *clk)
> +{
> + int ret;
> +
> + ret = clk_prepare(clk);
> + if (!ret)
> + ret = clk_enable(clk);
> + if (ret)
Using 'else' here makes the code more readable IMO.
baruch
> + clk_unprepare(clk);
> +
> + return ret;
> +}
> +
> +static inline void clk_disable_unprepare(struct clk *clk)
> +{
> + clk_disable(clk);
> + clk_unprepare(clk);
> +}
> +
> /**
> * clk_get_rate - obtain the current clock rate (in Hz) for a clock source.
> * This is only valid once the clock source has been enabled.
> --
> 1.7.5.4
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@...s.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists