Date:	Fri, 11 Nov 2011 17:05:09 -0200
From:	Flavio Leitner <fbl@...hat.com>
To:	Jiri Pirko <jpirko@...hat.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	eric.dumazet@...il.com, bhutchings@...arflare.com,
	shemminger@...tta.com, fubar@...ibm.com, andy@...yhouse.net,
	tgraf@...radead.org, ebiederm@...ssion.com, mirqus@...il.com,
	kaber@...sh.net, greearb@...delatech.com, jesse@...ira.com,
	benjamin.poirier@...il.com, jzupka@...hat.com, ivecera@...hat.com
Subject: Re: [patch net-next V7] net: introduce ethernet teaming device

On Fri, 11 Nov 2011 16:04:41 -0200
Flavio Leitner <fbl@...hat.com> wrote:

> On Thu, 10 Nov 2011 16:41:38 +0100
> Jiri Pirko <jpirko@...hat.com> wrote:
> 
> > This patch introduces new network device called team. It supposes to be
> > very fast, simple, userspace-driven alternative to existing bonding
> > driver.
> > 
> > Userspace library called libteam with couple of demo apps is available
> > here:
> > https://github.com/jpirko/libteam
> > Note it's still in its dipers atm.
> > 
> > team<->libteam use generic netlink for communication. That and rtnl
> > suppose to be the only way to configure team device, no sysfs etc.
> > 
> > Python binding of libteam was recently introduced.
> > Daemon providing arpmon/miimon active-backup functionality will be
> > introduced shortly. All what's necessary is already implemented in
> > kernel team driver.
> > 
> > Signed-off-by: Jiri Pirko <jpirko@...hat.com>
> > 
> > v6->v7:
> > 	- transmit and receive functions are not checked in hot paths.
> > 	  That also resolves memory leak on transmit when no port is
> > 	  present
> > 
> 
> You're right. No need to patch those function names if we use libnl
> from git.
> 
> [...]
> > +static void team_vlan_rx_add_vid(struct net_device *dev, uint16_t vid)
> > +{
> > +	struct team *team = netdev_priv(dev);
> > +	struct team_port *port;
> > +
> > +	rcu_read_lock();
> > +	list_for_each_entry_rcu(port, &team->port_list, list) {
> > +		const struct net_device_ops *ops = port->dev->netdev_ops;
> > +
> > +		ops->ndo_vlan_rx_add_vid(port->dev, vid);
> 
> This causes a oops when enslaving a tg3 device because there is
> no ndo_vlan_rx_add_vid().
> 
Sorry, I should have said when bring team0 up:

[root@...i7 ~]# ip link set team0 up
Killed

BUG: unable to handle kernel NULL pointer dereference at           (null)
IP: [<          (null)>]           (null)
PGD 18ee5b067 PUD 18d9cd067 PMD 0
Oops: 0010 [#1] SMP
d_timer snd soundcore snd_page_alloc pl2303 usbserial iTCO_wdt iTCO_vendor_support raid0 i2c_i801 pcspkr microcode serio_raw uinput floppy joydev ipv6 autofs4 ata_generic firewire_ohci pata_acpi firewire_core crc_itu_t pata_marvell nouveau ttm drm_kms_helper drm hwmon i2c_algo_bit i2c_core mxm_wmi wmi video [last unloaded: scsi_wait_scan]

Pid: 21877, comm: ip Not tainted 3.2.0-rc1-10901-g40709d7 #31                  /DX58SO
RIP: 0010:[<0000000000000000>]  [<          (null)>]           (null)
RSP: 0018:ffff88018eecd6a0  EFLAGS: 00010283
RAX: ffffffffa02a4370 RBX: ffff8801a4d04500 RCX: 0000000000000e7f
RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff880198356000
RBP: ffff88018eecd6d8 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000000 R11: ffff880181d57600 R12: 0000000000000000
R13: ffff8801a526f7d8 R14: ffffffffa032f0c0 R15: 0000000000000000
FS:  00007f52ae475700(0000) GS:ffff8801afcc0000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 0000000000000000 CR3: 00000001983ab000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process ip (pid: 21877, threadinfo ffff88018eecc000, task ffff88018db8aea0)
Stack:
 ffffffffa01e21ca ffffffff81a36700 ffff8801a4d04518 ffff8801a526f000
 0000000000000001 ffff8801a526f000 00000000fffffff0 ffff88018eecd738
 ffffffffa03062f5 ffff88018eecd708 00000000000080fe ffff88018eecd6f8
Call Trace:
 [<ffffffffa01e21ca>] ? team_vlan_rx_add_vid+0x45/0x69 [team]
 [<ffffffffa03062f5>] vlan_device_event+0xd5/0x3e2 [8021q]
 [<ffffffff8148e97b>] notifier_call_chain+0x37/0x63
 [<ffffffff8106d2a4>] raw_notifier_call_chain+0x14/0x16
 [<ffffffff813d1fb1>] call_netdevice_notifiers+0x4a/0x4f
 [<ffffffff813d636d>] __dev_notify_flags+0x37/0x5b
 [<ffffffff813d63d9>] dev_change_flags+0x48/0x54
 [<ffffffff813e0ace>] do_setlink+0x2b0/0x7a5
 [<ffffffff8123c078>] ? __nla_reserve+0x26/0x4e
 [<ffffffff813e19ed>] rtnl_newlink+0x253/0x46e
 [<ffffffff813e184b>] ? rtnl_newlink+0xb1/0x46e
 [<ffffffff813e158f>] rtnetlink_rcv_msg+0x23b/0x251
 [<ffffffff813e1354>] ? __rtnl_unlock+0x17/0x17
 [<ffffffff813f55d5>] netlink_rcv_skb+0x42/0x8d
 [<ffffffff813e06aa>] rtnetlink_rcv+0x26/0x2d
 [<ffffffff813f5164>] netlink_unicast+0xec/0x156
 [<ffffffff813f53c9>] netlink_sendmsg+0x1fb/0x233
 [<ffffffff813c27f7>] sock_sendmsg+0xe6/0x109
 [<ffffffff81229308>] ? radix_tree_lookup_slot+0xe/0x10
 [<ffffffff810cb0c8>] ? unlock_page+0x27/0x2b
 [<ffffffff810e67b8>] ? __do_fault+0x351/0x38b
 [<ffffffff8103ae47>] ? should_resched+0xe/0x2d
 [<ffffffff8148a03d>] ? _cond_resched+0xe/0x22
 [<ffffffff8103ae47>] ? should_resched+0xe/0x2d
 [<ffffffff813cc733>] ? copy_from_user+0x2f/0x31
 [<ffffffff813ccb1e>] ? verify_iovec+0x52/0xa4
 [<ffffffff813c2adc>] __sys_sendmsg+0x213/0x2ba
 [<ffffffff810e5eaa>] ? pmd_offset+0x19/0x3f
 [<ffffffff810e9008>] ? handle_mm_fault+0x103/0x118
 [<ffffffff8148e8ed>] ? do_page_fault+0x343/0x39a
 [<ffffffff810ed7a3>] ? do_brk+0x23f/0x293
 [<ffffffff813c46ee>] sys_sendmsg+0x42/0x60
 [<ffffffff81491d82>] system_call_fastpath+0x16/0x1b
Code:  Bad RIP value.
RIP  [<          (null)>]           (null)
 RSP <ffff88018eecd6a0>
CR2: 0000000000000000
---[ end trace 8255e7c0eb274d5c ]---

fbl
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists