netdev - Re: [PATCH] r8169: add module param for control of ASPM disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111112104624.GA24870@electric-eye.fr.zoreil.com>
Date:	Sat, 12 Nov 2011 11:46:24 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Todd Broch <tbroch@...omium.org>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>,
	Realtek linux nic maintainers <nic_swsd@...ltek.com>,
	netdev@...r.kernel.org, Hayes Wang <hayeswang@...ltek.com>
Subject: Re: [PATCH] r8169: add module param for control of ASPM  disable

Matthew Garrett <mjg59@...f.ucam.org> :
> On Fri, Nov 11, 2011 at 03:05:55PM -0800, Todd Broch wrote:
> > ASPM has been disabled in this driver by default as its been
> > implicated in stability issues on at least one platform.  This CL adds
> > a  module parameter to allow control of ASPM disable.  The default
> > value is to enable ASPM again as its provides signficant (200mW) power
> > savings on the platform I tested.
> 
> The default is then to break some hardware. That's not reasonable. 
> Instead, we need to identify which chip versions are broken and limit 
> the blacklist to them.

Yes, assuming it's only a device problem.

Todd, which chipset(s) (XID or such) was it tested with ?

It would be nice to know the kind of use as well (desktop / laptop / server).

Btw, what is a 'CL' ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html