netdev - Re: [PATCH] ah: Don't return NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111112.181422.1840921776479927270.davem@davemloft.net>
Date:	Sat, 12 Nov 2011 18:14:22 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	nbowler@...iptictech.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ah: Don't return NET_XMIT_DROP on input.

From: Nick Bowler <nbowler@...iptictech.com>
Date: Thu, 10 Nov 2011 14:01:27 -0500

> When the ahash driver returns -EBUSY, AH4/6 input functions return
> NET_XMIT_DROP, presumably copied from the output code path.  But
> returning transmit codes on input doesn't make a lot of sense.
> Since NET_XMIT_DROP is a positive int, this gets interpreted as
> the next header type (i.e., success).  As that can only end badly,
> remove the check.
> 
> Signed-off-by: Nick Bowler <nbowler@...iptictech.com>

Applied and queued up for -stable, thanks Nick.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html