netdev - Re: [PATCH 1/1] net: fec: convert to clk_prepare/clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111113033427.GC2425@richard-laptop>
Date:	Sun, 13 Nov 2011 11:34:33 +0800
From:	Richard Zhao <richard.zhao@...aro.org>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	linux-arm-kernel@...ts.infradead.org, kernel@...gutronix.de,
	shawn.guo@...aro.org, eric.miao@...aro.org
Subject: Re: [PATCH 1/1] net: fec: convert to clk_prepare/clk_unprepare

Hi Uwe,
On Sat, Nov 12, 2011 at 01:49:39PM +0100, Uwe Kleine-König wrote:
> Hello Richard,
> 
> On Thu, Nov 10, 2011 at 01:01:44PM +0800, Richard Zhao wrote:
> > Signed-off-by: Richard Zhao <richard.zhao@...aro.org>
> > ---
> >  drivers/net/ethernet/freescale/fec.c |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
> > index 1124ce0..92e3585 100644
> > --- a/drivers/net/ethernet/freescale/fec.c
> > +++ b/drivers/net/ethernet/freescale/fec.c
> > @@ -1588,6 +1588,7 @@ fec_probe(struct platform_device *pdev)
> >  		ret = PTR_ERR(fep->clk);
> >  		goto failed_clk;
> >  	}
> > +	clk_prepare(fep->clk);
> What about error checking?
The goal of the patch is migrating to the new generic clock framework.
If the original driver has error check of clk_enable, I also added error check of
clk_prepare. And I've sent out new version patch, which use clk_prepare_enable.

Richard
> 
> Best regards
> Uwe
> 
> -- 
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html