netdev - Re: [PATCH FIX net v2] forcedeth: fix stats on hardware without extended stats support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111114.001514.2212530697656360412.davem@davemloft.net>
Date:	Mon, 14 Nov 2011 00:15:14 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	david.decotigny@...gle.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	ian.campbell@...rix.com, eric.dumazet@...il.com,
	jeffrey.t.kirsher@...el.com, jpirko@...hat.com, joe@...ches.com,
	szymon@...c.net.pl, rick.jones2@...com, AAbdulla@...dia.com
Subject: Re: [PATCH FIX net v2] forcedeth: fix stats on hardware without
 extended stats support

From: David Decotigny <david.decotigny@...gle.com>
Date: Fri, 11 Nov 2011 18:27:34 -0800

> This change makes sure that tx_packets/rx_bytes ifconfig counters are
> updated even on NICs that don't provide hardware support for these
> stats: they are now updated in software. For the sake of consistency,
> we also now have tx_bytes updated in software (hardware counters
> include ethernet CRC, and software doesn't account for it).
> 
> This reverts parts of:
>  - "forcedeth: statistics optimization" (21828163b2)
>  - "forcedeth: Improve stats counters" (0bdfea8ba8)
>  - "forcedeth: remove unneeded stats updates" (4687f3f364)
> 
> Tested:
>   pktgen + loopback (http://patchwork.ozlabs.org/patch/124698/)
>   reports identical tx_packets/rx_packets and tx_bytes/rx_bytes.
> 
> Signed-off-by: David Decotigny <david.decotigny@...gle.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html