[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20111114.153608.2064552703690099046.davem@davemloft.net>
Date: Mon, 14 Nov 2011 15:36:08 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: eric.dumazet@...il.com
Cc: sim@...tway.ca, tglx@...utronix.de, netdev@...r.kernel.org,
a.p.zijlstra@...llo.nl, linux-kernel@...r.kernel.org,
davej@...hat.com, schwidefsky@...ibm.com, mingo@...e.hu
Subject: Re: [3.1] Divide by zero in __tcp_select_window()
From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 08 Nov 2011 22:23:25 +0100
> OK, it seems we let a timer running while we free the socket (same error
> path than your previous bug report, because of the NULL route)
>
> We arm this keepalive timer in tcp_create_openreq_child()
>
> net/ipv4/tcp_minisocks.c:513
> if (sock_flag(newsk, SOCK_KEEPOPEN))
> inet_csk_reset_keepalive_timer(newsk,
> keepalive_time_when(newtp));
>
> I would try to add a call to tcp_clear_xmit_timers() as well
>
> Please try following patch :
We've been waiting quite some time to get some testing validation on
this patch, but I think it's correct.
Eric can you formally submit this? Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists