netdev - Re: [PATCH] net: fsl_pq_mdio: fix non tbi phy access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Nov 2011 21:04:47 +0000
From:	Fleming Andy-AFLEMING <afleming@...escale.com>
To:	Baruch Siach <baruch@...s.co.il>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Baruch Siach <baruch@...s.co.il>
Subject: Re: [PATCH] net: fsl_pq_mdio: fix non tbi phy access

Well, this got applied quickly, so I guess I can't NAK, but this requires discussion.

On Nov 14, 2011, at 0:22, "Baruch Siach" <baruch@...s.co.il> wrote:

> Since 952c5ca1 (fsl_pq_mdio: Clean up tbi address configuration) .probe returns
> -EBUSY when the "tbi-phy" node is missing. Fix this.

It returns an error because it finds no tbi node. Because without the tbi node, there is no way for the driver to determine which address to set.

Your solution is to ignore the error, and hope. That's a broken approach. The real solution for a p1010 should be to have a tbi node in the dts.

And looking at the p1010si.dtsi, I see that it's automatically there for you.

How were you breaking?

Andy

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html