netdev - Re: fsl_pq_mdio: Clean up tbi address configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111114061335.GA13389@sapphire.tkos.co.il>
Date:	Mon, 14 Nov 2011 08:13:35 +0200
From:	Baruch Siach <baruch@...s.co.il>
To:	Andy Fleming <afleming@...escale.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: fsl_pq_mdio: Clean up tbi address configuration

Hi Andy,

On Fri, Nov 11, 2011 at 05:10:39AM -0000, Andy Fleming wrote:
> The code for setting the address of the internal TBI PHY was
> convoluted enough without a maze of ifdefs. Clean it up a bit
> so we allow the logic to fail down to -ENODEV at the end of
> the if/else ladder, rather than using ifdefs to repeat the same
> failure code over and over.
> 
> Also, remove the support for the auto-configuration. I'm not aware of
> anyone using it, and it ends up using the bus mutex before it's been
> initialized.

With this applied I'm getting

fsl-pq_mdio: probe of ffe24000.mdio failed with error -16

on my P1011 board which does not have a "tbi-phy" node. I'll post a fix 
shortly.

baruch

> Signed-off-by: Andy Fleming <afleming@...escale.com>

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html