netdev - Re: [PATCH] ipv4: return NET_RX_DROP when arp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111115.164706.1420496299997283498.davem@davemloft.net>
Date:	Tue, 15 Nov 2011 16:47:06 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv4: return NET_RX_DROP when arp_rcv drops the
 received packet.

From: roy.qing.li@...il.com
Date: Tue, 15 Nov 2011 10:09:47 +0800

> From: RongQing.Li <roy.qing.li@...il.com>
> 
> return NET_RX_DROP when arp_rcv drops the received packet.
> 
> Signed-off-by: RongQing.Li <roy.qing.li@...il.com>

This is not appropriate.

NET_RX_DROP means that the packet was dropped because something about
the packet's contents were not acceptable, or the packet violated our
policies so was dropped.

In this arp_rcv() case, we would have accepted the packet, but we had
a memory allocation error.  This memory allocation error has nothing
to do with the packet's contents, and is a transient issue.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html