netdev - Re: [PATCH] Add ethtool to mii advertisment conversion helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111116.173618.213297028503733251.davem@davemloft.net>
Date:	Wed, 16 Nov 2011 17:36:18 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mcarlson@...adcom.com
Cc:	netdev@...r.kernel.org, mchan@...adcom.com
Subject: Re: [PATCH] Add ethtool to mii advertisment conversion helpers

From: "Matt Carlson" <mcarlson@...adcom.com>
Date: Tue, 15 Nov 2011 14:00:53 -0800

> Translating between ethtool advertisement settings and MII
> advertisements are common operations for ethernet drivers.  This patch
> adds a set of helper functions that implements the conversion.  The
> patch then modifies a couple of the drivers to use the new functions.
> 
> Signed-off-by: Matt Carlson <mcarlson@...adcom.com>
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Doesn't build:

In file included from drivers/net/ethernet/3com/3c59x.c:82:0:
include/linux/mii.h: In function ‘ethtool_adv_to_mii_100bt’:
include/linux/mii.h:254:15: error: ‘ADVERTISED_10baseT_Half’ undeclared (first use in this function)
include/linux/mii.h:254:15: note: each undeclared identifier is reported only once for each function it appears in
include/linux/mii.h:256:15: error: ‘ADVERTISED_10baseT_Full’ undeclared (first use in this function)
include/linux/mii.h:258:15: error: ‘ADVERTISED_100baseT_Half’ undeclared (first use in this function)
include/linux/mii.h:260:15: error: ‘ADVERTISED_100baseT_Full’ undeclared (first use in this function)
include/linux/mii.h:262:15: error: ‘ADVERTISED_Pause’ undeclared (first use in this function)
include/linux/mii.h:264:15: error: ‘ADVERTISED_Asym_Pause’ undeclared (first use in this function)