netdev - Re: [PATCH v5 7/9] ethtool: prepare for larger netdev_features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Nov 2011 00:18:51 +0100
From:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v5 7/9] ethtool: prepare for larger netdev_features_t
 type

On Wed, Nov 16, 2011 at 10:43:29PM +0000, Ben Hutchings wrote:
> On Wed, 2011-11-16 at 02:29 +0100, Michał Mirosław wrote:
> > v2:	changed loop in ethtool_set_features() per Ben's suggestion
> > 
> > Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> Run checkpatch and fix the spacing complaints.  After that, consider
> this:

There are two lines longer than 80 chars, but it won't improve readability
if I split them. No spacing complaints on my run of checkpatch:

WARNING: line over 80 characters
#51: FILE: net/core/ethtool.c:91:
+       BUILD_BUG_ON(ETHTOOL_DEV_FEATURE_WORDS*sizeof(u32) > sizeof(netdev_features_t));

WARNING: line over 80 characters
#57: FILE: net/core/ethtool.c:97:
+               features[i].never_changed = (u32)(NETIF_F_NEVER_CHANGE >> (32*i));

total: 0 errors, 2 warnings, 75 lines checked

/tmp/0007-ethtool-prepare-for-larger-netdev_features_t-type.patch has style problems, please review.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html