netdev - Re: [PATCH 1/2] net: add network priority cgroup infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111117115630.GA21527@hmsreliant.think-freely.org>
Date:	Thu, 17 Nov 2011 06:56:31 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	John Fastabend <john.r.fastabend@...el.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Love, Robert W" <robert.w.love@...el.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 1/2] net: add network priority cgroup infrastructure

On Thu, Nov 17, 2011 at 03:25:58AM -0800, John Fastabend wrote:
> On 11/16/2011 12:51 PM, Neil Horman wrote:
> > This patch adds in the infrastructure code to create the network priority
> > cgroup.  The cgroup, in addition to the standard processes file creates two
> > control files:
> > 
> > 1) prioidx - This is a read-only file that exports the index of this cgroup.
> > This is a value that is both arbitrary and unique to a cgroup in this subsystem,
> > and is used to index the per-device priority map
> > 
> > 2) priomap - This is a writeable file.  On read it reports a table of 2-tuples
> > <name:priority> where name is the name of a network interface and priority is
> > indicates the priority assigned to frames egresessing on the named interface and
> > originating from a pid in this cgroup
> > 
> > This cgroup allows for skb priority to be set prior to a root qdisc getting
> > selected. This is benenficial for DCB enabled systems, in that it allows for any
> > application to use dcb configured priorities so without application modification
> > 
> > Signed-off-by: Neil Horman <nhorman@...driver.com>
> > Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> > CC: Robert Love <robert.w.love@...el.com>
> > CC: "David S. Miller" <davem@...emloft.net>
> > ---
> >  include/linux/cgroup_subsys.h |    8 +
> >  include/linux/netdevice.h     |    4 +
> >  include/net/netprio_cgroup.h  |   66 ++++++++
> >  include/net/sock.h            |    3 +
> >  net/Kconfig                   |    7 +
> >  net/core/Makefile             |    1 +
> >  net/core/dev.c                |   13 ++
> >  net/core/netprio_cgroup.c     |  340 +++++++++++++++++++++++++++++++++++++++++
> >  net/core/sock.c               |   22 +++-
> >  net/socket.c                  |    2 +
> >  10 files changed, 465 insertions(+), 1 deletions(-)
> >  create mode 100644 include/net/netprio_cgroup.h
> >  create mode 100644 net/core/netprio_cgroup.c
> > 
> 
> Hi Neil,
> 
> couple more comments.
> 
Thanks John, I'll fix these points up and post a v2 later today.
Neil

> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html