netdev - Re: Unable to flush ICMP redirect routes in kernel 3.0+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1321551536.2751.87.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Thu, 17 Nov 2011 18:38:56 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Flavio Leitner <fbl@...hat.com>
Cc:	David Miller <davem@...emloft.net>,
	Ivan Zahariev <famzah@...soft.com>, netdev@...r.kernel.org,
	Vasiliy Kulikov <segoon@...nwall.com>
Subject: Re: Unable to flush ICMP redirect routes in kernel 3.0+

Le jeudi 17 novembre 2011 à 18:18 +0100, Eric Dumazet a écrit :
> Le jeudi 17 novembre 2011 à 15:01 -0200, Flavio Leitner a écrit :
> 
> > Right, so the loop trying different oif and saddr isn't working at
> > all because __ip_route_output_key() will create a route in the first
> > attempt.  Looks like you're right and we need the 'create' parameter
> > in __ip_route_output_key().
> 
> And we have to loop on all possible keys combinations.
> 
> (like code before David commit (f39925dbde77 ipv4: Cache learned
> redirect information in inetpeer.) : it had a goto do_next;
> 
> I am preparing a patch.
> 


Unfortunately its not enough.

For some reason, ipv4_dst_check() is not called later, so we cant call
ipv4_dst_check() and change 
rt->rt_gateway = peer->redirect_learned.a4;

dst->obsolete strikes again.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html