netdev - Re: [PATCH] Add ethtool to mii advertisment conversion helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1321492892.9114.22.camel@nseg_linux_HP1.broadcom.com>
Date:	Wed, 16 Nov 2011 17:21:32 -0800
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Matt Carlson" <mcarlson@...adcom.com>
cc:	"Ben Hutchings" <bhutchings@...arflare.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] Add ethtool to mii advertisment conversion helpers


On Wed, 2011-11-16 at 17:16 -0800, Matt Carlson wrote:
> > Finally, do these need to be inline?
> 
> I don't have a strong preference here either.  Phy code tends to be
> slower, so there isn't really a strong performance argument.  The
> implementations don't seem to be so large to argue against it though.
> Would you prefer they not be inlined?
> 

Since we are defining these in .h file, they need to be inline, right?
Otherwise multiple source files including the same .h file will have
conflict.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html