netdev - Re: [PATCH] Add ethtool to mii advertisment conversion helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1321496967.2885.65.camel@deadeye>
Date:	Thu, 17 Nov 2011 02:29:27 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
CC:	<mchan@...adcom.com>, <mcarlson@...adcom.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] Add ethtool to mii advertisment conversion helpers

On Wed, 2011-11-16 at 20:38 -0500, David Miller wrote:
> From: "Michael Chan" <mchan@...adcom.com>
> Date: Wed, 16 Nov 2011 17:21:32 -0800
> 
> > 
> > On Wed, 2011-11-16 at 17:16 -0800, Matt Carlson wrote:
> >> > Finally, do these need to be inline?
> >> 
> >> I don't have a strong preference here either.  Phy code tends to be
> >> slower, so there isn't really a strong performance argument.  The
> >> implementations don't seem to be so large to argue against it though.
> >> Would you prefer they not be inlined?
> >> 
> > 
> > Since we are defining these in .h file, they need to be inline, right?
> > Otherwise multiple source files including the same .h file will have
> > conflict.
> 
> Yes, if you keep them in the header you have to keep them inline.
> 
> Ben, by suggesting to not inline them, is implicitly saying to put
> them out in a seperate *.c file somewhere, perhaps net/core/ethtool.c
> or similar.  With appropriate EXPORT_SYMBOL() added.

I was thinking of putting them in drivers/net/mii.c, like the other
functions declared extern in include/linux/mii.h.  That would require
'select MII' in Kconfig for the drivers using them.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html