netdev - Re: [PATCH 4/5] stmmac: remove spin_lock in stmmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111117.031430.491721529337695679.davem@davemloft.net>
Date:	Thu, 17 Nov 2011 03:14:30 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org, francesco.virlinzi@...com,
	srinivas.kandagatla@...com
Subject: Re: [PATCH 4/5] stmmac: remove spin_lock in stmmac_ioctl.

From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
Date: Thu, 17 Nov 2011 08:58:01 +0100

> From: Srinivas Kandagatla <srinivas.kandagatla@...com>
> 
> This patch removes un-needed spin_lock in stmmac_ioctl while reading and
> writing mdio registers. While holding spin_lock the code must be
> atomic, which is not true in this case as both mdiobus_read and writes
> have mutex locks.
> 
> Without this patch reading mdio registers via mii-tool results in below
> BUG:
> mii-tool -vvv eth0"
> Using SIOCGMIIPHY=0x8947
> BUG: sleeping function called from invalid context at kernel/mutex.c:287
 ...
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...com>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html