netdev - Re: Unable to flush ICMP redirect routes in kernel 3.0+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111118152142.717324b1@asterix.rh>
Date:	Fri, 18 Nov 2011 15:21:42 -0200
From:	Flavio Leitner <fbl@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Ivan Zahariev <famzah@...soft.com>, netdev@...r.kernel.org,
	Vasiliy Kulikov <segoon@...nwall.com>
Subject: Re: Unable to flush ICMP redirect routes in kernel 3.0+

On Fri, 18 Nov 2011 18:07:53 +0100
Eric Dumazet <eric.dumazet@...il.com> wrote:

> Le vendredi 18 novembre 2011 à 15:05 -0200, Flavio Leitner a écrit :
> 
> > Sorry, I meant that we are trying to avoid doing this:
> > +			hash = rt_hash(daddr, skeys[s],
> > ikeys[i],rt_genid(net)); +
> > +			rthp = &rt_hash_table[hash].chain;
> > +
> > +			while ((rt = rcu_dereference(*rthp)) !=
> > NULL) {
> > +				rthp = &rt->dst.rt_next;
> 
> Sure, but this is still needed right now.

Yes, David will not be happy, unfortunately :)

> Once route cache is removed, this loop wont exist anymore ;)

That's the problem, we need to get rid of it first. :)

fbl
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html