| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20111118191722.GA16429@aepfle.de> Date: Fri, 18 Nov 2011 20:17:22 +0100 From: Olaf Hering <olaf@...fle.de> To: Ben Hutchings <bhutchings@...arflare.com> Cc: netdev@...r.kernel.org, xen-devel@...ts.xensource.com, Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> Subject: Re: [PATCH] xen-netfront: report link speed to ethtool On Fri, Nov 18, Ben Hutchings wrote: > On Fri, 2011-11-18 at 19:43 +0100, Olaf Hering wrote: > > On Fri, Nov 18, Ben Hutchings wrote: > > > > > On Fri, 2011-11-18 at 17:48 +0100, Olaf Hering wrote: > > > > The reported data refers to VMWare vmxnet. > > > NAK, we should not just make things up. > > > > So how about removing veth_get_settings, vmxnet3_get_settings, > > tun_get_settings and other functions that escaped my grep? > > If they can't provide meaningful information then maybe they should be > removed. However, that could result in a regression for existing > working configurations. (This isn't the same as the case you're trying > to fix, since those applications have never worked with xen-netfront or > many other drivers that don't implement get_settings.) That may be. How about a new generic ethtool_op_get_settings_veth which returns fake values for all relevant drivers (virtio, xen-netfront, and the ones listed above)? Olaf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists