netdev - Re: [PATCH net-next] bnx2: switch to build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111118.020905.956112543630839327.davem@davemloft.net>
Date:	Fri, 18 Nov 2011 02:09:05 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, eilong@...adcom.com
Subject: Re: [PATCH net-next] bnx2: switch to build_skb() infrastructure

From: "Michael Chan" <mchan@...adcom.com>
Date: Thu, 17 Nov 2011 20:47:24 -0800

> 
> On Tue, 2011-11-15 at 09:30 -0800, Eric Dumazet wrote:
>> This is very similar to bnx2x conversion, but bnx2 only requires 16bytes
>> alignement at start of the received frame to store its l2_fhdr, so goal
>> was not to reduce skb truesize (in fact it should not change after this
>> patch)
>> 
>> Using build_skb() reduces cache line misses in the driver, since we
>> use cache hot skb instead of cold ones. Number of in-flight sk_buff
>> structures is lower, they are more likely recycled in SLUB caches
>> while still hot.
>> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
>> CC: Michael Chan <mchan@...adcom.com>
>> CC: Eilon Greenstein <eilong@...adcom.com>
> 
> Looks good.  Thanks.
> 
> Reviewed-by: Michael Chan <mchan@...adcom.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html