netdev - Re: WARNING: at mm/slub.c:3357, kernel BUG at mm/slub.c:3413

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1321894353.10470.19.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Mon, 21 Nov 2011 17:52:33 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Markus Trippelsdorf <markus@...ppelsdorf.de>
Cc:	"Alex,Shi" <alex.shi@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Pekka Enberg <penberg@...nel.org>,
	Matt Mackall <mpm@...enic.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, tj@...nel.org
Subject: Re: WARNING: at mm/slub.c:3357, kernel BUG at mm/slub.c:3413

Le lundi 21 novembre 2011 à 17:10 +0100, Markus Trippelsdorf a écrit :

> Sure. This one happend with CONFIG_DEBUG_PAGEALLOC=y:
> 
> [drm] Initialized radeon 2.11.0 20080528 for 0000:01:05.0 on minor 0
> loop: module loaded
> ahci 0000:00:11.0: version 3.0
> ahci 0000:00:11.0: PCI INT A -> GSI 22 (level, low) -> IRQ 22
> ahci 0000:00:11.0: AHCI 0001.0100 32 slots 6 ports 3 Gbps 0x3f impl SATA mode
> ahci 0000:00:11.0: flags: 64bit ncq sntf ilck pm led clo pmp pio slum part ccc 
> scsi0 : ahci
> scsi1 : ahci
> =============================================================================
> BUG task_struct: Poison overwritten
> -----------------------------------------------------------------------------

Unfortunately thats the same problem, not catched by DEBUG_PAGEALLOC
because freed page is immediately reused.

We should keep pages in free list longer, to have a bigger window.

Hmm...

Please try following patch :

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 9dd443d..b8932a6 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1196,7 +1196,7 @@ void free_hot_cold_page(struct page *page, int cold)
 	}
 
 	pcp = &this_cpu_ptr(zone->pageset)->pcp;
-	if (cold)
+	if (IS_ENABLED(CONFIG_DEBUG_PAGEALLOC) || cold)
 		list_add_tail(&page->lru, &pcp->lists[migratetype]);
 	else
 		list_add(&page->lru, &pcp->lists[migratetype]);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html