[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1321907158-27857-2-git-send-email-jorge@dti2.net>
Date: Mon, 21 Nov 2011 21:25:54 +0100
From: "Jorge Boncompte [DTI2]" <jorge@...2.net>
To: netdev@...r.kernel.org, linux-atm-general@...ts.sourceforge.net
Cc: "Jorge Boncompte [DTI2]" <jorge@...2.net>
Subject: [PATCH 1/5] atm: br2684: Do not move counters backwards
From: "Jorge Boncompte [DTI2]" <jorge@...2.net>
This snippet has caused several bugs in the past, and I don't see the
point on substracting the skb len from netdev stats.
Signed-off-by: Jorge Boncompte [DTI2] <jorge@...2.net>
---
net/atm/br2684.c | 9 +--------
1 files changed, 1 insertions(+), 8 deletions(-)
diff --git a/net/atm/br2684.c b/net/atm/br2684.c
index d07223c..81cf33b 100644
--- a/net/atm/br2684.c
+++ b/net/atm/br2684.c
@@ -557,15 +557,8 @@ static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg)
skb_queue_splice_init(rq, &queue);
spin_unlock_irqrestore(&rq->lock, flags);
- skb_queue_walk_safe(&queue, skb, tmp) {
- struct net_device *dev;
-
+ skb_queue_walk_safe(&queue, skb, tmp)
br2684_push(atmvcc, skb);
- dev = skb->dev;
-
- dev->stats.rx_bytes -= skb->len;
- dev->stats.rx_packets--;
- }
/* initialize netdev carrier state */
if (atmvcc->dev->signal == ATM_PHY_SIG_LOST)
--
1.7.7.1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists