netdev - Re: [PATCH 1/2] net: add network priority cgroup infrastructure (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111121204307.GA10900@hmsreliant.think-freely.org>
Date:	Mon, 21 Nov 2011 15:43:07 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, john.r.fastabend@...el.com,
	robert.w.love@...el.com
Subject: Re: [PATCH 1/2] net: add network priority cgroup infrastructure (v3)

On Mon, Nov 21, 2011 at 03:39:23PM -0500, David Miller wrote:
> From: Neil Horman <nhorman@...driver.com>
> Date: Fri, 18 Nov 2011 11:13:40 -0500
> 
> 
> > +#ifdef CONFIG_CGROUPS
> > +void skb_update_prio(struct sk_buff *skb)
> > +{
> > +	struct netprio_map *map = rcu_dereference(skb->dev->priomap);
> > +
> > +	if ((!skb->priority) && (skb->sk) && map)
> > +		skb->priority = map->priomap[skb->sk->sk_cgrp_prioidx];
> > +}
> > +EXPORT_SYMBOL_GPL(skb_update_prio);
> > +#endif
> 
> skb_update_prio() has one call site, right here in this dev.c file.
> Mark it static, kill the symbol export, and use the ifdef here to nop
> out the implementation when the config option isn't set.
> 
> > +	struct netprio_map *map;
> > +
> > +	rtnl_lock();
> > +
> > +
> > +	for_each_netdev(&init_net, dev) {
> 
> There are a few instances of extra empty lines in the code added by
> this patch, please do a quick audit and get rid of them.
> 
> Otherwise seems ok to me.
> 
> Thanks.
Copy that Dave, will respin and repost in the AM.
Neil

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html