netdev - Re: [PATCH net-next] tg3: switch to build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111121.161116.13047257344687921.davem@davemloft.net>
Date:	Mon, 21 Nov 2011 16:11:16 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, eilong@...adcom.com, mchan@...adcom.com,
	mcarlson@...adcom.com
Subject: Re: [PATCH net-next] tg3: switch to build_skb() infrastructure

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 18 Nov 2011 17:47:01 +0100

> This is very similar to bnx2x conversion, but simpler since no special
> alignement is required, so goal was not to reduce skb truesize.
> 
> Using build_skb() reduces cache line misses in the driver, since we
> use cache hot skb instead of cold ones. Number of in-flight sk_buff
> structures is lower, they are more likely recycled in SLUB caches
> while still hot.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> CC: Matt Carlson <mcarlson@...adcom.com>
> CC: Michael Chan <mchan@...adcom.com>
> CC: Eilon Greenstein <eilong@...adcom.com>

I've applied this because I know Eric gave it a good testing :-)

I really like how the build_skb() interface allows us to overlap
the prefetch of skb->data with the allocation of the SKB metadata.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html