netdev - Re: [patch v2] caif: fix endian conversion in cffrml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJK669bL51Ct-Q9LxXwFdiaQAnfkx2Um1k0Cutci2z6mdd2THw@mail.gmail.com>
Date:	Mon, 21 Nov 2011 22:20:09 +0100
From:	Sjur Brændeland <sjurbren@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch v2] caif: fix endian conversion in cffrml_transmit()

> The "tmp" variable here is used to store the result of cpu_to_le16()
> so it should be an __le16 instead of an int.  We want the high bits
> set and the current code works on little endian systems but not on
> big endian systems.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> v2:  In v1 I used a u16 instead of an __le16.  Also I've changed the
> name to "data" instead of "tmp".

Thanks Dan, good catch - this would have failed badly on a b_e architecture.

Acked-by: Sjur Brændeland <sjur.brandeland@...ricsson.com>

Regards,
Sjur
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html