netdev - Re: [patch] fix error handle in ip_mc_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1321889410.14281.31.camel@barry.pixelworks.com>
Date:	Mon, 21 Nov 2011 23:30:10 +0800
From:	Jun Zhao <mypopydev@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [patch] fix error handle in ip_mc_add_src()

On Mon, 2011-11-21 at 16:24 +0100, Eric Dumazet wrote:
> Le lundi 21 novembre 2011 à 23:05 +0800, Jun Zhao a écrit :
> > When add sources to interface failure, need to roll back the sfcount[MODE] 
> > to before state. We need to match it corresponding. 
> > 
> 
> Missing "---" separator
> 
> > diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
> > index c7472ef..276719a 100644
> > --- a/net/ipv4/igmp.c
> > +++ b/net/ipv4/igmp.c
> > @@ -1716,7 +1716,8 @@ static int ip_mc_add_src(struct in_device *in_dev, __be32 *pmca, int sfmode,
> >  	if (err) {
> >  		int j;
> >  
> > -		pmc->sfcount[sfmode]--;
> > +		if(!delta)
> 
> Missing space, should be  : if (!delta)
> 
> > +			pmc->sfcount[sfmode]--;
> >  		for (j=0; j<i; j++)
> >  			(void) ip_mc_del1_src(pmc, sfmode, &psfsrc[j]);
> >  	} else if (isexclude != (pmc->sfcount[MCAST_EXCLUDE] != 0)) {
> > 
> > Signed-off-by: Jun Zhao <mypopydev@...il.com>
> > 
> 
> Your "Signed-off-by:" should come before actual patch
> 
> Please read Documentation/SubmittingPatches
> 
> Thanks
> 
> 
> 

Tks, Eric Dumazet , I will re-submit this patch and follow the format.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html