netdev - Re: [PATCH net-next V2] tg3: Fix advertisement handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111122.151806.1120520761351993603.davem@davemloft.net>
Date:	Tue, 22 Nov 2011 15:18:06 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	shimoda.hiroaki@...il.com
Cc:	mcarlson@...adcom.com, mchan@...adcom.com, eric.dumazet@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next V2] tg3: Fix advertisement handling

From: Hiroaki SHIMODA <shimoda.hiroaki@...il.com>
Date: Tue, 22 Nov 2011 23:05:41 +0900

> Commit 28011cf19b (net: Add ethtool to mii advertisment conversion
> helpers) added a helper function ethtool_adv_to_mii_100bt() and
> tg3_copper_is_advertising_all(), tg3_phy_autoneg_cfg() were
> modified to use this.
> Before that commit, ethtool to mii advertisement conversion was
> done wrt speed, but now pause operation is also taken account.
> So, in tg3_copper_is_advertising_all(), below condition becomes
> true and this makes link up fails.
> 
> 	if ((adv_reg & ADVERTISE_ALL) != all_mask)
> 		return 0;
> 
> To fix this add ADVERTISE_ALL bit and operation to cap speed,
> and change default advertisement not including ADVERTISED_Pause.
> 
> Reported-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@...il.com>
> ---
> V2: change default advertisement not including ADVERTISED_Pause

I'll apply this, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html