netdev - Re: [PATCH 0/2] net: Add network priority cgroup (v4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111122.154516.228225371031125826.davem@davemloft.net>
Date:	Tue, 22 Nov 2011 15:45:16 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	nhorman@...driver.com
Cc:	netdev@...r.kernel.org, john.r.fastabend@...el.com,
	robert.w.love@...el.com
Subject: Re: [PATCH 0/2] net: Add network priority cgroup (v4)

From: Neil Horman <nhorman@...driver.com>
Date: Tue, 22 Nov 2011 15:39:38 -0500

> On Tue, Nov 22, 2011 at 03:23:15PM -0500, David Miller wrote:
>> From: Neil Horman <nhorman@...driver.com>
>> Date: Tue, 22 Nov 2011 10:10:50 -0500
>> 
>> > (v2)
>> > Based on reviews from John F., Amerigo Wang and Neerav Parikh, I've cleaned up
>> > the rcu locking, fixed a memory leak in an error path, and corrected some typos.
>> > 
>> > (v3)
>> > Converted rcu_dereference to rntl_dereference where appropriate as per request
>> > from John F.
>> > 
>> > (v4)
>> > Cleaned up some spacing issues, and optimized the skb_update_priority path as
>> > per request from Dave M.
>> > 
>> > Signed-off-by: Neil Horman <nhorman@...driver.com>
>> > Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
>> > CC: Robert Love <robert.w.love@...el.com>
>> > CC: "David S. Miller" <davem@...emloft.net>
>> 
>> Applied and going through some build testing now, thanks Neil.
> Thanks Dave!  I tested here building separately with:
> CONFIG_CGROUPS=n
> CONFIG_CROUPS=y && CONFIG_NETPRIO_CGROUP=y
> CONFIG_CROUPS=y && CONFIG_NETPRIO_CGROUP=m
> 
> So you should be square, but theres rarely any valid accounting for my ability
> to screw something up :)

I want to be absolutely sure, because I had to apply your changes by hand,
in particular the linux/netdevice.h changes had line offsets of up to 67.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html