netdev - Re: WARNING: at mm/slub.c:3357, kernel BUG at mm/slub.c:3413

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1322000195.14573.13.camel@pasglop>
Date:	Wed, 23 Nov 2011 09:16:35 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Christian Kujau <lists@...dbynature.de>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Christoph Lameter <cl@...ux.com>,
	Markus Trippelsdorf <markus@...ppelsdorf.de>,
	"Alex,Shi" <alex.shi@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	Pekka Enberg <penberg@...nel.org>,
	Matt Mackall <mpm@...enic.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Tejun Heo <tj@...nel.org>
Subject: Re: WARNING: at mm/slub.c:3357, kernel BUG at mm/slub.c:3413

On Tue, 2011-11-22 at 00:39 -0800, Christian Kujau wrote:
> On Tue, 22 Nov 2011 at 08:48, Eric Dumazet wrote:
> > > --- linux-2.6.orig/mm/slub.c	2011-11-21 21:15:41.575673204 -0600
> > > +++ linux-2.6/mm/slub.c	2011-11-21 21:16:33.442336849 -0600
> > > @@ -1969,7 +1969,7 @@
> > >  		page->pobjects = pobjects;
> > >  		page->next = oldpage;
> > > 
> > > -	} while (this_cpu_cmpxchg(s->cpu_slab->partial, oldpage, page) != oldpage);
> > > +	} while (irqsafe_cpu_cmpxchg(s->cpu_slab->partial, oldpage, page) != oldpage);
> > >  	stat(s, CPU_PARTIAL_FREE);
> > >  	return pobjects;
> > >  }
> 
> Is this a patch to try for my PowerPC machine? With CONFIG_SLUB=y?
> 
> > For x86, I wonder if our !X86_FEATURE_CX16 support is correct on SMP
> > machines.
> 
> I'm on UP, don't have any x68/SMP machines to test atm :(

Yes, please try the patch with SLUB and let us know if it makes a
difference.

Eric, Christoph, the generic version of this_cpu_cmpxchg() is not
interrupt safe, so I suppose this patch should go in right ?

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html