netdev - Re: MPLS for Linux kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Nov 2011 14:55:36 +0100
From:	Igor Maravić <igorm@....rs>
To:	jorge@...2.net
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: MPLS for Linux kernel

2011/11/22 Jorge Boncompte [DTI2] <jorge@...2.net>:
>        You keep insisting in that you fixed a lot of things, but you have provided a
> git tree with just one big commit and say that have taken some of my patches on
> it, could you please provide patches on TOP of the sourceforge code for the
> things that are not fixed there?

I insist on that because I did do a lot of things. When I did send you
patch, on TOP of your net-next code, about the most important bug
(stack overflow that was happening when mpls nhlfe entry was built)
that I fixed it was just ignored. Unfortunately I started  fixing MPLS
code without git, and I added your patches manually.

> It seems to me that you have not noticed that while
> fixing bugs I have reworked a lot of code to make it cleaner or simpler, simply
> deleted it and fixed the style.

Yes I saw that

>        What's needs to be done, and it's on my TODO list...
>
>        The kernel code that is not commented out on the mpls-linux code when you build
> the kernel it the shim layer and it's not done on purpose. This code was written
> by James to be a generic feature of the networking layer. Now I am not sure that
> it has any value keeping it and am for removing it.

I didn't understand what did You want to say here.

>        The other thing that probably I am going to remove is the labelspace support. I
> don't see a use for it, and even Cisco doesn't implement it either that I know.

That's 15 min of work, but I think that labelspaces should stay.

>        Then we must rework the netlink interface to make it cleaner and extensible.

What do you mean by extensible? With my netlink code you can add,
change and delete ilm, nhlfe and xc entries without any problem. What
other could one wish for? As I could see in your code you can't change
ilm, nhlfe and xc entries.

>        Check the dst's usages, there has been a lot of changes in the core kernel here
> lately and I am not sure if we are using it correctly.

As far I could see you did a great job of using nhlfe as dst entry.
Problem was when you delete nhlfe entry that is referenced with ilm
entry. It shouldn't be allowed to be deleted, or the ilm should change
last instructions from fwd to peek. I did the last thing.
Also there was the problem with neighbor hh_cache, because we are
using nhlfe as dst_entry but I fixed that too.  (hh_cache wouldn't
change when we are sending packets with diferent type (ETH_P_IP and
ETH_P_MPLS_UC))
Also ilm shouldn't be dst_entry. I'm going to change that.

>        Check the locking and RCU usage.

There where few problems about that, that I fixed.

BR
Igor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html