netdev - Re: [PATCH] netns: fix proxy ARP entries listing on a netns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111123.173613.1360696422325749253.davem@davemloft.net>
Date:	Wed, 23 Nov 2011 17:36:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jorge@...2.net
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] netns: fix proxy ARP entries listing on a netns

From: "Jorge Boncompte [DTI2]" <jorge@...2.net>
Date: Mon, 21 Nov 2011 20:46:14 +0100

> @@ -2397,6 +2397,7 @@ static struct pneigh_entry *pneigh_get_next(struct seq_file *seq,
>  	struct net *net = seq_file_net(seq);
>  	struct neigh_table *tbl = state->tbl;
>  
> +restart:
>  	pn = pn->next;
>  	while (!pn) {

We don't need to use goto to fix this bug, instead change this assignment
to something like:

	do {
		pn = pn->next;
	} while (pn && !net_eq(pneigh_net(pn), net));

and this way it will mirror the while loop inside of the "while (!pn)"
code block.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html