netdev - Re: [PATCH v3 0/10] bql: Byte Queue Limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1322028037.1298.6.camel@edumazet-laptop>
Date:	Wed, 23 Nov 2011 07:00:37 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v3 0/10] bql: Byte Queue Limits

Le mardi 22 novembre 2011 à 21:52 -0800, Tom Herbert a écrit :
> Changes from last version:
>   - Rebase to 3.2
>   - Added CONFIG_BQL and CONFIG_DQL
>   - Added some cache alignment in struct dql, to split read only, writeable
>     elements, and split those elements written on transmit from those
>     written at transmit completion (suggested by Eric).
>   - Split out adding xps_queue_release as its own patch.
>   - Some minor performance changes, use likely and unlikely for some
>     conditionals.
>   - Cleaned up some "show" functions for bql (pointed out by Ben).
>   - Change netdev_tx_completed_queue to do check xoff, check
>     availability, and then check xoff again.  This to prevent potential
>     race conditions with netdev_sent_queue (as Ben pointed out).
>   - Did some more testing trying to evaluate overhead of BQL in the
>     transmit path.  I see about 1-3% degradation in CPU utilization
>     and maximum pps when BQL is enabled.  Any ideas to beat this
>     down as much as possible would be appreciated!
>   - Added high versus low priority traffic test to results below.
>   

Excellent, I plan to review and test this today

Thanks !



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html