[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20111123065240.GD6871@elgon.mountain>
Date: Wed, 23 Nov 2011 09:52:40 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Ralf Baechle <ralf@...ux-mips.org>
Cc: "David S. Miller" <davem@...emloft.net>,
linux-hams@...r.kernel.org, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: [patch] netrom: check that user string is terminated
We do an strcpy() of mnemonic in nr_add_node().
Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index 915a87b..e126c48 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -670,6 +670,8 @@ int nr_rt_ioctl(unsigned int cmd, void __user *arg)
case SIOCADDRT:
if (copy_from_user(&nr_route, arg, sizeof(struct nr_route_struct)))
return -EFAULT;
+ if (strlen(nr_route.mnemonic) >= sizeof(nr_route.mnemonic))
+ return -EINVAL;
if ((dev = nr_ax25_dev_get(nr_route.device)) == NULL)
return -EINVAL;
if (nr_route.ndigis < 0 || nr_route.ndigis > AX25_MAX_DIGIS) {
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists