netdev - Re: [patch v2 1/1] fix error handle in ip_mc_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ECCADDD.5040606@foxmail.com>
Date:	Wed, 23 Nov 2011 16:25:01 +0800
From:	ShanWei <davidshan@...mail.com>
To:	Jun Zhao <mypopydev@...il.com>
CC:	davem@...emloft.net, Eric Dumazet <eric.dumazet@...il.com>,
	netdev@...r.kernel.org, David Stevens <dlstevens@...ibm.com>
Subject: Re: [patch v2 1/1] fix error handle in ip_mc_add_src()

Jun Zhao said, at 2011/11/22 0:05:
> from: Jun Zhao<mypopydev@...il.com>
>
> When add sources to interface failure, need to roll back the sfcount[MODE]
> to before state. We need to match it corresponding.
>
> Acked-by: David L Stevens<dlstevens@...ibm.com>
> Acked-by: Eric Dumazet<eric.dumazet@...il.com>
> Signed-off-by: Jun Zhao<mypopydev@...il.com>
> ---
> diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
> index c7472ef..b2ca095 100644
> --- a/net/ipv4/igmp.c
> +++ b/net/ipv4/igmp.c
> @@ -1716,7 +1716,8 @@ static int ip_mc_add_src(struct in_device *in_dev, __be32 *pmca, int sfmode,
>          if (err) {
>                  int j;
>
> -               pmc->sfcount[sfmode]--;
> +               if (!delta)
> +                       pmc->sfcount[sfmode]--;

Tab is changed to space by your email client.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html