netdev - Re: [PATCH 0/2] net: Add network priority cgroup (v4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111123114926.GA27968@hmsreliant.think-freely.org>
Date:	Wed, 23 Nov 2011 06:49:26 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	Kirill Smelkov <kirr@....spb.ru>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	john.r.fastabend@...el.com, robert.w.love@...el.com
Subject: Re: [PATCH 0/2] net: Add network priority cgroup (v4)

On Wed, Nov 23, 2011 at 02:19:34PM +0400, Kirill Smelkov wrote:
> On Tue, Nov 22, 2011 at 04:00:08PM -0500, Neil Horman wrote:
> > On Tue, Nov 22, 2011 at 03:45:16PM -0500, David Miller wrote:
> > > From: Neil Horman <nhorman@...driver.com>
> > > Date: Tue, 22 Nov 2011 15:39:38 -0500
> > > 
> > > > On Tue, Nov 22, 2011 at 03:23:15PM -0500, David Miller wrote:
> > > >> From: Neil Horman <nhorman@...driver.com>
> > > >> Date: Tue, 22 Nov 2011 10:10:50 -0500
> > > >> 
> > > >> > (v2)
> > > >> > Based on reviews from John F., Amerigo Wang and Neerav Parikh, I've cleaned up
> > > >> > the rcu locking, fixed a memory leak in an error path, and corrected some typos.
> > > >> > 
> > > >> > (v3)
> > > >> > Converted rcu_dereference to rntl_dereference where appropriate as per request
> > > >> > from John F.
> > > >> > 
> > > >> > (v4)
> > > >> > Cleaned up some spacing issues, and optimized the skb_update_priority path as
> > > >> > per request from Dave M.
> > > >> > 
> > > >> > Signed-off-by: Neil Horman <nhorman@...driver.com>
> > > >> > Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> > > >> > CC: Robert Love <robert.w.love@...el.com>
> > > >> > CC: "David S. Miller" <davem@...emloft.net>
> > > >> 
> > > >> Applied and going through some build testing now, thanks Neil.
> > > > Thanks Dave!  I tested here building separately with:
> > > > CONFIG_CGROUPS=n
> > > > CONFIG_CROUPS=y && CONFIG_NETPRIO_CGROUP=y
> > > > CONFIG_CROUPS=y && CONFIG_NETPRIO_CGROUP=m
> > > > 
> > > > So you should be square, but theres rarely any valid accounting for my ability
> > > > to screw something up :)
> > > 
> > > I want to be absolutely sure, because I had to apply your changes by hand,
> > > in particular the linux/netdevice.h changes had line offsets of up to 67.
> > Really?  Thats odd, I've got thse changes here applied to a local copy of the
> > net-next tree.  I branched from commit 8b3408f8ee994973869d8ba32c5bf482bc4ddca4
> > and it applies cleanly.  Perhaps something wen't in while I was developing this?
> 
> The patch broke the build with CONFIG_CGROUPS=n (testing on today's
> net-next v3.2-rc2-714-g1f2149c):
> 
> kirr@...i:~/src/linux/linux-net-next$ make
>   CHK     include/linux/version.h
>   CHK     include/generated/utsrelease.h
>   CALL    scripts/checksyscalls.sh
>   CHK     include/generated/compile.h
>   CC      init/do_mounts.o
> In file included from include/linux/netdevice.h:53,
>                  from include/linux/icmpv6.h:173,
>                  from include/linux/ipv6.h:220,
>                  from include/net/ipv6.h:16,
>                  from include/linux/sunrpc/clnt.h:26,
>                  from include/linux/nfs_fs.h:50,
>                  from init/do_mounts.c:20:
> include/net/netprio_cgroup.h:23: error: field ‘css’ has incomplete type
> scripts/Makefile.build:305: recipe for target `init/do_mounts.o' failed
> make[1]: *** [init/do_mounts.o] Error 1
> Makefile:945: recipe for target `init' failed
> make: *** [init] Error 2
> 
> 
> Config attached.
> 
Damn, I apologize.  I had tested with CGROUP_CONFIG=n, but when I did a make
oldconfig, since I had cgroup subsystems enabled, it re-selected CGROUP_CONFIG,
instead of squashing the subsystems.  I'll fix this immediately.  
Neil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html