netdev - Re: [PATCH v3 03/10] net: Add netdev interfaces recording send/compl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Nov 2011 16:03:20 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	David Miller <davem@...emloft.net>
Cc:	therbert@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3 03/10] net: Add netdev interfaces recording
 send/compl

On Wed, 23 Nov 2011 18:58:12 -0500 (EST)
David Miller <davem@...emloft.net> wrote:

> From: Stephen Hemminger <shemminger@...tta.com>
> Date: Wed, 23 Nov 2011 09:46:14 -0800
> 
> > Since all the drivers that you show do this for one packet at a time,
> > why bother with a packets arguement to netdev_sent_queue()?
> 
> They batch the completion, that's why f.e. e1000e's changes keep track of
> pkts_compl and bytes_compl, and then pass that in at the end of the TX
> completion processing so that we only invoke these interfaces once per
> run instead of once per packet.

I was referring to the transmit routine, there for netdev_sent_queue()
is always called with one packet.

Many drivers batch packets in completion, and call netdev_completed_queue()
with multiple packets (and bytes).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html