netdev - Re: [PATCH] net: fsl_pq_mdio: fix oops when using uninitialized mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Nov 2011 01:50:58 -0600
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Andy Fleming <afleming@...il.com>
Cc:	Baruch Siach <baruch@...s.co.il>, netdev@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org,
	Andy Fleming <afleming@...escale.com>
Subject: Re: [PATCH] net: fsl_pq_mdio: fix oops when using uninitialized mutex


On Nov 9, 2011, at 2:10 PM, Andy Fleming wrote:

>> Fix this by moving the of_mdiobus_register() call earlier.
>> 
>> Cc: Andy Fleming <afleming@...escale.com>
>> Signed-off-by: Baruch Siach <baruch@...s.co.il>
>> ---
>>  drivers/net/ethernet/freescale/fsl_pq_mdio.c |   14 +++++++-------
>>  1 files changed, 7 insertions(+), 7 deletions(-)
>> 
>> diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
>> index 52f4e8a..e17fd2f 100644
>> --- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
>> +++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
>> @@ -385,6 +385,13 @@ static int fsl_pq_mdio_probe(struct platform_device *ofdev)
>>                        tbiaddr = *prop;
>>        }
>> 
>> +       err = of_mdiobus_register(new_bus, np);
>> +       if (err) {
>> +               printk (KERN_ERR "%s: Cannot register as MDIO bus\n",
>> +                               new_bus->name);
>> +               goto err_free_irqs;
>> +       }
>> +
> 
> 
> This fix totally breaks the point of setting tbipa beforehand.
> mdiobus_register will cause the bus to be scanned, and if any of the
> PHYs are at the default address for tbipa, they won't be found. I have
> a different fix which I will (re)submit today.

What happened here, did you send a patch?

- k--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html