netdev - Re: [PATCH] virtio_net: Give indication on device probe failure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF0C38CC5A.2D445246-ON65257952.002F945B-65257952.00301BA1@in.ibm.com>
Date:	Thu, 24 Nov 2011 14:17:43 +0530
From:	Krishna Kumar2 <krkumar2@...ibm.com>
To:	Sasha Levin <levinsasha928@...il.com>
Cc:	davem@...emloft.net, mst@...hat.com, netdev@...r.kernel.org,
	rusty@...tcorp.com.au
Subject: Re: [PATCH] virtio_net: Give indication on device probe failure.

Sasha Levin <levinsasha928@...il.com> wrote on 11/24/2011 02:05:22 PM:

> > Provide an indication when the virtio_net device fails to
> > initialize.
> >
> > Signed-off-by: Krishna Kumar <krkumar2@...ibm.com>
> > ---
>
> [snip]
>
> You already get a warning from the thingie that probes PCI:
>
> [    1.166311] virtio_net: probe of virtio1 failed with error -12

Ah, I created this patch based on your feedback:

> I would suggest adding some output if we take the failure path, since
> while the guest does boot peacefully, it doesn't have a network
> interface and there's nothing in the boot log to indicate anything has
> gone wrong.

Is this probe error enough to find there was a problem,
or do you think detailed error in all fail cases is
required?

Thanks,

- KK

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html