netdev - Re: [PATCH net] net: Revert ARCNET and PHYLIB to tristate options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111125.013102.841551383223873520.davem@davemloft.net>
Date:	Fri, 25 Nov 2011 01:31:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	debian-kernel@...ts.debian.org
Subject: Re: [PATCH net] net: Revert ARCNET and PHYLIB to tristate options

From: Ben Hutchings <ben@...adent.org.uk>
Date: Thu, 24 Nov 2011 07:23:30 +0000

> Commit 88491d8103498a6166f70d5999902fec70924314 ("drivers/net: Kconfig
> & Makefile cleanup") changed the type of these options to bool, but
> they select code that could (and still can) be built as modules.
> 
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
> I consider the inability to build arcnet.o and libphy.o as modules to be
> a regression in 3.2 for general-purpose distribution kernels.
> Therefore, please apply this to the net tree.

I challenge you to get PHYLIB set to 'm' in a configuration such as
"allmodconfig" which is clearly in line with the kind of configuration
which "distribution kernels" use.

Did you really even try to see if it mattered?  Or did you just test
your change with a stripped down configuration you happened to have
readily available in some build tree?

I really consider this change entirely pointless, because for the
situation where you say it matters, it actually doesn't as far as I
can tell.

I'm therefore rejecting this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html