netdev - Re: [PATCH iproute2 1/2] utils: add s32 parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111125111333.GA2810@hell>
Date:	Fri, 25 Nov 2011 12:13:34 +0100
From:	Hagen Paul Pfeifer <hagen@...u.net>
To:	David Laight <David.Laight@...LAB.COM>
Cc:	netdev@...r.kernel.org, Stephen Hemminger <shemminger@...tta.com>
Subject: Re: [PATCH iproute2 1/2] utils: add s32 parser

* David Laight | 2011-11-25 09:46:09 [-0000]:

>> +int get_s32(__s32 *val, const char *arg, int base)
>> +{
>> +	long res;
>> +	char *ptr;
>> +
>> +	if (!arg || !*arg)
>> +		return -1;
>
>No need to check *arg, picked up below.

Yes, it is a little bit explicit/duplicate, but I decided to follow all
get_[su][16 32 64] functions to be consistent. If you want you can send a
separate patch afterwards.

HGN
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html