netdev - Re: [PATCH net-next 2/8] dsa: Export functions from core to modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111127191556.GQ795@wantstofly.org>
Date:	Sun, 27 Nov 2011 20:15:56 +0100
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/8] dsa: Export functions from core to modules

On Sat, Nov 26, 2011 at 12:34:07AM +0000, Ben Hutchings wrote:

> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
>  net/dsa/dsa.c   |    2 ++
>  net/dsa/slave.c |    2 ++
>  2 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
> index 66f5c04..fc93088 100644
> --- a/net/dsa/dsa.c
> +++ b/net/dsa/dsa.c
> @@ -29,6 +29,7 @@ void register_switch_driver(struct dsa_switch_driver *drv)
>  	list_add_tail(&drv->list, &dsa_switch_drivers);
>  	mutex_unlock(&dsa_switch_drivers_mutex);
>  }
> +EXPORT_SYMBOL_GPL(register_switch_driver);
>  
>  void unregister_switch_driver(struct dsa_switch_driver *drv)
>  {
> @@ -36,6 +37,7 @@ void unregister_switch_driver(struct dsa_switch_driver *drv)
>  	list_del_init(&drv->list);
>  	mutex_unlock(&dsa_switch_drivers_mutex);
>  }
> +EXPORT_SYMBOL_GPL(unregister_switch_driver);
>  
>  static struct dsa_switch_driver *
>  dsa_switch_probe(struct mii_bus *bus, int sw_addr, char **_name)

ACK on these.


> diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> index 56cf9b8..c9d52ca 100644
> --- a/net/dsa/slave.c
> +++ b/net/dsa/slave.c
> @@ -45,6 +45,7 @@ void dsa_slave_mii_bus_init(struct dsa_switch *ds)
>  			ds->master_mii_bus->id, ds->pd->sw_addr);
>  	ds->slave_mii_bus->parent = &ds->master_mii_bus->dev;
>  }
> +EXPORT_SYMBOL_GPL(dsa_slave_mii_bus_init);
>  
> 
>  /* slave device handling ****************************************************/
> @@ -402,3 +403,4 @@ dsa_slave_create(struct dsa_switch *ds, struct device *parent,
>  
>  	return slave_dev;
>  }
> +EXPORT_SYMBOL_GPL(dsa_slave_create);

Why do these need to be exported?  They are only called from dsa.c,
and dsa.c and slave.c are always linked into the same entity, even
after your patches.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html